Check for missing dependencies before building the website#1678
Merged
sonichi merged 1 commit intomicrosoft:mainfrom Feb 16, 2024
Merged
Check for missing dependencies before building the website#1678sonichi merged 1 commit intomicrosoft:mainfrom
sonichi merged 1 commit intomicrosoft:mainfrom
Conversation
- Add an executable permission to the file. - Check for dependencies before the build starts. - Output a list of missing dependencies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1678 +/- ##
=======================================
Coverage 37.80% 37.80%
=======================================
Files 50 50
Lines 5726 5726
Branches 1296 1296
=======================================
Hits 2165 2165
Misses 3390 3390
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…#1678) - Add an executable permission to the file. - Check for dependencies before the build starts. - Output a list of missing dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
command -vis POSIX compatible.Sample output:
Why are these changes needed?
TL;DR: make the life of anyone who wants to contribute to the documentation (and doesn't necessary run all the steps described in
README.md;-)) easier. My workflow consisted of 5-6 retries till I got all the dependencies right. This set of changes reduces the frustration and performs the dependency checks beforehand.Related issue number
Checks