Skip to content

.NET: Suppress false positive Zip Slip alert - #7858

Merged
SergeyMenshykh merged 5 commits into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-suppress-zip-slip-alert
Aug 25, 2026
Merged

.NET: Suppress false positive Zip Slip alert#7858
SergeyMenshykh merged 5 commits into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-suppress-zip-slip-alert

Conversation

@SergeyMenshykh

Copy link
Copy Markdown
Contributor

Motivation & Context

Suppresses the false-positive CodeQL Zip Slip finding SM02729.

Description & Review Guide

  • What are the major changes? Add an inline CodeQL suppression with justification.
  • What is the impact of these changes? No runtime behavior changes.
  • What do you want reviewers to focus on? The suppression justification.

Related Issue

N/A - internal CodeQL finding SM02729.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) - a workflow keeps the label and title prefix in sync automatically.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
Copilot AI balanced review requested due to automatic review settings August 25, 2026 10:40
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Aug 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a justified inline CodeQL suppression for a false-positive Zip Slip finding. Runtime behavior is unchanged.

Changes:

  • Suppresses SM02729 where archive destinations are validated by ResolveDestination.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@SergeyMenshykh SergeyMenshykh self-assigned this Aug 25, 2026
@SergeyMenshykh
SergeyMenshykh marked this pull request as ready for review August 25, 2026 10:42
@SergeyMenshykh SergeyMenshykh moved this to In Progress in Agent Framework Aug 25, 2026
@SergeyMenshykh SergeyMenshykh moved this from In Progress to In Review in Agent Framework Aug 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): ebb03924eda7
Model: gpt-5.6-sol

Overview

This PR adds only an inline CodeQL suppression and does not alter runtime behavior. The justification is supported by canonical path resolution, separator-aware containment checks, rejection before filesystem writes, and tests covering traversal and case-sensitive sibling escapes. No publishable issue was introduced by the change.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
This was referenced Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants