.NET: docs(decisions): resolve duplicate ADR sequence numbers (0016, 0021, 0024) - #6046
Conversation
John CSA (jluocsa)
left a comment
There was a problem hiding this comment.
Author verification note (not a self-approval — flagging for reviewer convenience):
What I verified before pushing:
-
Tiebreaker policy applied consistently. For each colliding pair, the file that kept its number is the one with stronger "anchoring" signal:
0016→ keptpython-context-middleware.md(status:accepted, cited 5× by0019-python-context-compaction-strategy.md).0021→ keptprovider-leading-clients.md(status:accepted, dated 2026-03-20 vsagent-skills-designproposed 2026-03-23).0024→ keptprompt-injection-defense.md(proposed 2026-01-14, earlier thancodeact-integrationproposed 2026-04-07).
-
No content changes. All three operations are pure
git mv— diff shows 3 files renamed, 0 insertions, 0 deletions, 100% similarity. Commit SHA:e8a91efe9ae5d07d5a0a4d4ffb073bc5d8485c00. -
No dangling cross-references. Searched
docs/decisions/for references to the moved files by their old numbers (ADR-0016 structured,0016-structured-output,ADR-0021 agent-skills,0021-agent-skills-design,ADR-0024 codeact,0024-codeact-integration) — none found outside the renamed files themselves. The 5 citations ofADR-0016in0019-python-context-compaction-strategy.mdcorrectly refer to the keptpython-context-middleware.md. -
Sequence integrity post-merge: new highest assigned number becomes
0029. Next free number is0030. -
Out of scope (intentionally):
- No reorganizing ADRs by date or theme.
- No edit to
docs/decisions/README.md— its existing guidance ("Check for existing PRs to make sure you use the correct sequence number") already addresses the root cause.
If maintainers prefer a different tiebreaker (e.g., always keep the earlier-dated file regardless of status), I can re-run the renames with the alternative policy — the operation is mechanical and reversible.
|
Updated to fix the Verified with |
702e537 to
c2ab48b
Compare
|
Rebased onto current When I opened this, the plan was
So merging the original version would have created new collisions (0027 ×2, 0028 ×2, 0029 ×4) rather than removing them. Worth flagging that git still reported this as a clean merge — renames to new filenames never conflict textually, so the collision wouldn't have shown up in the merge check. This is now renumbered onto the next free slots instead:
The renames are pure One thing worth a separate issue: three duplicate pairs remain on |
…0024)
Three ADR pairs in docs/decisions/ shared sequence numbers despite the directory README's guidance to pick unique numbers. This commit renames the file in each pair that does not already have established cross-references.
Renames:
0016-structured-output.md -> 0027-structured-output.md
0021-agent-skills-design.md -> 0028-agent-skills-design.md
0024-codeact-integration.md -> 0029-codeact-integration.md
Pure rename; no content edits.
Motivation and Context
Description
Contribution Checklist