[api] Add .getNonMissingTypeOfSymbol() method - #63956
Open
Tom Mrazauskas (mrazauskas) wants to merge 1 commit into
Open
[api] Add .getNonMissingTypeOfSymbol() method#63956Tom Mrazauskas (mrazauskas) wants to merge 1 commit into
.getNonMissingTypeOfSymbol() method#63956Tom Mrazauskas (mrazauskas) wants to merge 1 commit into
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
typescript-automation
Bot
added
the
For Uncommitted Bug
Copilot started reviewing on behalf of
Tom Mrazauskas (mrazauskas)
August 22, 2026 06:13
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a checker API that returns symbol types while respecting exactOptionalPropertyTypes, resolving #63829.
Changes:
- Exposes and registers
getNonMissingTypeOfSymbol. - Adds synchronous and asynchronous TypeScript APIs.
- Tests behavior with exact optional property types enabled and disabled.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/checker/exports.go |
Exposes the checker operation. |
tsc/internal/api/session.go |
Handles the new API request. |
tsc/internal/api/proto.go |
Registers protocol serialization. |
packages/typescript/src/api/proto.generated.ts |
Adds generated protocol typing. |
packages/typescript/src/api/sync/api.ts |
Adds the synchronous API. |
packages/typescript/src/api/async/api.ts |
Adds the asynchronous API. |
packages/typescript/test/sync/api.test.ts |
Tests synchronous behavior. |
packages/typescript/test/async/api.test.ts |
Tests asynchronous behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening microsoft/typescript-go#4701
This PR adds the
.getNonMissingTypeOfSymbol()getter to the checker instance.As it was mentioned in microsoft/typescript-go#4701 (comment), an alternative solution could be changing the implementation of
handleGetTypeOfSymbol(). Replacingchecker.GetTypeOfSymbol(symbol)withchecker.GetTypeOfSymbolAtLocation(symbol, nil)would enable.getTypeOfSymbol()to respect theexactOptionalPropertyTypesoption without adding an additional method.Fixes #63829