Fix go-to-type-definition for tuple aliases - #63913
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Open
Fix go-to-type-definition for tuple aliases#63913Mateusz Burzyński (Andarist) wants to merge 1 commit into
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
For Milestone Bug
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
August 20, 2026 12:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes go-to-type-definition for tuple aliases by falling back to the type’s alias symbol when no direct symbol exists.
Changes:
- Resolve declarations through alias symbols.
- Add regression coverage for a named tuple alias.
- Update the expected fourslash baseline.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tsc/internal/ls/definition.go |
Adds alias-symbol fallback for type declarations. |
tsc/internal/fourslash/tests/goToTypeWithTupleTypes_test.go |
Adds the tuple-alias regression case. |
tsc/testdata/baselines/reference/fourslash/goToType/goToTypeWithTupleTypes1.baseline.jsonc |
Records the expected navigation targets. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #63762