Repository navigation
Fix emit for nested object rest in assignment pattern - #52922
Merged
Merged
Conversation
Ron Buckton (rbuckton)
requested review from
Andrew Branch (andrewbranch) and
Jake Bailey (jakebailey)
February 22, 2023 22:00
Member
|
TypeScript Bot (@typescript-bot) perf test faster |
Contributor
|
Heya Jake Bailey (@jakebailey), I've started to run the abridged perf test suite on this PR at 773caf5. You can monitor the build here. Update: The results are in! |
Contributor
|
Jake Bailey (@jakebailey) Here they are:Comparison Report - main..52922
System
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Jake Bailey (jakebailey)
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the downlevel emit for object rest destructuring when nested in an array destructuring, or in the ForInitializer of a
for..ofloop. This does not fix the emit forfor..in, however, as we currently report an error for that cases.Fixes #43400