Fixed substition types for non-generic indexed accesses - #51621
Merged
Anders Hejlsberg (ahejlsberg) merged 1 commit intoDec 7, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Nathan Shively-Sanders (sandersn)
requested review from
Anders Hejlsberg (ahejlsberg) and
Wesley Wigham (weswigham)
December 5, 2022 23:43
Member
There was a problem hiding this comment.
See my reasoning here for why I don't think this change is a good idea.
EDIT: Turns out there is a meaningful scenario after all.
Anders Hejlsberg (ahejlsberg)
approved these changes
Dec 7, 2022
Mateusz Burzyński (Andarist)
deleted the
andarist/fix-non-generic-substitution-type
branch
December 7, 2022 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51614
this is a regression from https://github.com/microsoft/TypeScript/pull/50397/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8R13886
cc Anders Hejlsberg (@ahejlsberg)