Repository navigation
Fix more tests missing 'it' call in 'describe' - #48994
Merged
Jake Bailey (jakebailey) merged 1 commit intoMay 6, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found more of these while debugging the parser.
describecalls need to have anitcall in them, otherwise all of that code runs before the tests are filtered, e.g. when debugging or running a single test, which is super annoying.I tried adding
--fail-zeroto ourmochathing, but it doesn't seem to catch this because it was only designed to catch when you accidentally remove every test, not when a "suite" is missing any tests. Feels like this is worth a lint rule.