Skip to content

Add method signature handler to getTypeOfVariableOrParameterOrProperty #20825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 1 commit into from
Dec 29, 2017
Merged

Add method signature handler to getTypeOfVariableOrParameterOrProperty #20825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4683,7 +4683,8 @@ namespace ts {
else if (isJSDocPropertyTag(declaration)
|| isPropertyAccessExpression(declaration)
|| isIdentifier(declaration)
|| isMethodDeclaration(declaration) && !isObjectLiteralMethod(declaration)) {
|| (isMethodDeclaration(declaration) && !isObjectLiteralMethod(declaration))
|| isMethodSignature(declaration)) {
// TODO: Mimics old behavior from incorrect usage of getWidenedTypeForVariableLikeDeclaration, but seems incorrect
type = tryGetTypeFromEffectiveTypeNode(declaration) || anyType;
}
Expand Down
12 changes: 12 additions & 0 deletions tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
//// [methodSignatureHandledDeclarationKindForSymbol.ts]
interface Foo {
bold(): string;
}

interface Foo {
bold: string;
}



//// [methodSignatureHandledDeclarationKindForSymbol.js]
16 changes: 16 additions & 0 deletions tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
=== tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts ===
interface Foo {
>Foo : Symbol(Foo, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 0), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 2, 1))

bold(): string;
>bold : Symbol(Foo.bold, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 15), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 4, 15))
}

interface Foo {
>Foo : Symbol(Foo, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 0), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 2, 1))

bold: string;
>bold : Symbol(Foo.bold, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 15), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 4, 15))
}


16 changes: 16 additions & 0 deletions tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
=== tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts ===
interface Foo {
>Foo : Foo

bold(): string;
>bold : string
}

interface Foo {
>Foo : Foo

bold: string;
>bold : string
}


8 changes: 8 additions & 0 deletions tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
interface Foo {
bold(): string;
}

interface Foo {
bold: string;
}