Incorrect ES5 transpilation for try/catch + super

[nevedaren]

🔎 Search Terms

ES5, this alias

🕗 Version & Regression Information

• This changed between versions 5.1.6 and 5.2.2

⏯ Playground Link

https://www.typescriptlang.org/play?target=1&ts=5.2.2#code/IYIwzgLgTsDGEAJYBthjAgYge2wg3gFAJLYB2kUArvNlABRgAW2VyAJgCpNTYDuALgQhcyAKbAyASgLESCAJYAzBIxZsuPfjKLz5ELXwRkxRgKJReDAOQAFcWjEIoY6AE9rUgNxySAXwQxZDAnXT1SCmxxADpkbABzemsAeQBpTx89Pzls7MIUNAwAIWAoQIAPCDEydgwcPDDYckoaCDp6HV8Ed1lwhDAqAAcxBmgqMW8ugNhgCFgmVTEhKjIAazJ+aV7wpsiYuMTrCyshawQAakWENARjuilogFsxdGB4iczwgHov51coNxdEgDYYMJTAYIfKY5Qh5ExGEoMbxAA

💻 Code

// @target: es5
// @showEmit: true

abstract class Foo {
  constructor(shouldThrow: boolean) {
    if (shouldThrow) {
      throw new Error('Please retry');
    } else {
      console.log('OK');
    }
  }
}

class Bar extends Foo {
  constructor() {
    try {
      super(true);
    } catch (e: unknown) {
      console.log('Error: ' + (e as Error).message);
      // retry
      super(false);
    }
  }
}

new Bar();

Target: ES5

🙁 Actual behavior

_this is not defined 

🙂 Expected behavior

No error

Additional information about the issue

In TS5.2.2 output var _this = this; has been removed, but _this is still being used.

[fatcerberus]

Probably related to as #55637, as both involve a use of this (though indirectly, in this case) in a class constructor which broke in 5.2.

edit: Just realized you posted that other issue too 😆

[typescript-bot]

The change between v5.1.6 and v5.2.2 occurred at f9cf821.

[andrewbranch]

Same bisect result, so probably the same thing as #55637