Repository navigation
TS 5.0 - ModuleResolutionKind Enum changed (breaking change that's not listed) #53131
Description
Bug Report
ts.ModuleResolutionKind seems to have changed between 4.9 and 5. The enum now has a Node10 value which I guess is the old NodeJs. This isn't mentioned in the API breaking changes list, so this is either a bug (which will probably break a few libraries [for example the rollup typescript plugin, through which I discovered this]) or should be added to that list.
(for me personally, if you want to keep the name change, it would be best to first deprecate the old name and remove it later)
🔎 Search Terms
ModuleResolutionKind
🕗 Version & Regression Information
- This changed between versions 4.9 and 5.0
⏯ Playground Link
Doesn't apply here
💻 Code
ts.ModuleResolutionKind.NodeJs🙁 Actual behavior
Error
🙂 Expected behavior
No error
Activity
jakebailey commentedon Mar 7, 2023
NodeJswas changed toNode10in #51901, and I'm also noticing some cross-linked changes to that PR of people working around this.Andrew Branch (@andrewbranch) Should we have left behind a deprecated enum member?
(It is of course 5.0 where we made loads of breaking changes, so we could just document it.)
andrewbranch commentedon Mar 7, 2023
I may have meant to make it a breaking change; I don’t remember. But it’s very easy to make it backward-compatible. It’s probably best to add
NodeJsback.