Skip to content

values are marked deprecated when only type has @deprecated #39474

Closed
Closed
values are marked deprecated when only type has @deprecated#39474
Assignees
sandersn
Labels
BugA bug in TypeScriptDomain: JSDocRelates to JSDoc parsing and type generationEffort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".Help WantedYou can do this
Milestone
TypeScript 4.0.1

Description

@rbuckton
Ron Buckton (rbuckton)
opened on Jul 7, 2020

TypeScript Version: 4.0.0-dev.20200701

Search Terms: jsdoc deprecated tag

Code

interface ESMap<K, V> { }

/** @deprecated */
interface Map<T> extends ESMap<string, T> {}

declare const Map: new <K, V>() => ESMap<K, V>;

new Map<string, number>(); // 'Map' is crossed out

Expected behavior:

  • Map the value is not deprecated and should not be crossed out.

Actual behavior:

  • Map the value is considered deprecated, even though Map the type is not part of the value declaration of Map:

In VSCode:
image

In Playground:
image

Playground Link: https://www.typescriptlang.org/play/index.html?ts=4.0.0-dev.20200707#code/KYDwDg9gTgLgBAbzgXwNwCh0EsB2NhQBmAhgMbBwCiAygLLFgA8A0gDRwBqAfIipgPQAqQXAACAE2BgowUsXzi4g-tjwES5OPSYAVHqHw5xAZyp0GjYzCi4A5uz2JkmSaQA2xGXFIQcVrQwAXHA4wADucCzs3AAUAJRwALw8NNpRnFwYmOihEWlWNjj2IQCuALYARgRc8ahw-PxwAOTaTXBYpj5+WJIyipLSsvLAijHGwBQAjiVYpADW7TiEEHFAA

Related Issues: #38523

Activity

  1. Daniel Rosenwasser (DanielRosenwasser)
    added
    BugA bug in TypeScript
    Domain: JSDocRelates to JSDoc parsing and type generation
    on Jul 8, 2020
  2. Daniel Rosenwasser (DanielRosenwasser)
    assigned
    Nathan Shively-Sanders (sandersn)
    on Jul 8, 2020
  3. Daniel Rosenwasser (DanielRosenwasser)
    added this to the Typescript 4.0.1 milestone on Jul 8, 2020
  4. Daniel Rosenwasser (DanielRosenwasser)
    added
    Effort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".
    Help WantedYou can do this
    on Jul 8, 2020

  5. DanielRosenwasser commented on Jul 8, 2020

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Jul 8, 2020
    Member

    Probably look into getSemanticMeaning, then add some special cases. See if that is useful.

  6. Nathan Shively-Sanders (sandersn)
    changed the title [-]jsdoc deprecated tag is too aggressive[/-] [+]value are marked deprecated when only type has @deprecated[/+] on Jul 8, 2020
  7. Nathan Shively-Sanders (sandersn)
    changed the title [-]value are marked deprecated when only type has @deprecated[/-] [+]values are marked deprecated when only type has @deprecated[/+] on Jul 8, 2020

  8. sandersn commented on Jul 9, 2020

    @sandersn
    Nathan Shively-Sanders (sandersn)
    on Jul 9, 2020
    Member

    Fixed by #39323

  9. Nathan Shively-Sanders (sandersn)
    closed this as completedon Jul 9, 2020
  10. microsoft
    locked as resolved and limited conversation to collaborators on Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: JSDocRelates to JSDoc parsing and type generationEffort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".Help WantedYou can do this

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions