Skip to content

Fix accessibility bug 2201717 a11y heading structure #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navya9singh merged 1 commit into from
Jul 1, 2026
+12 −5
Merged

Fix accessibility bug 2201717 a11y heading structure #3600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tsconfig-reference/copy/en/options/extends.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ base config file, and that circularity between configuration files is not allowe

Currently, the only top-level property that is excluded from inheritance is [`references`](#references).

##### Example
#### Example

`configs/base.json`:

Expand Down
8 changes: 6 additions & 2 deletions packages/typescriptlang-org/src/templates/tsconfig.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
@import "../style/globals.scss";

.tsconfig-page-title {
margin-bottom: 1.5rem;
}

.tsconfig {
margin-bottom: 6rem;
// Drastically reduce the padding and margins to make it fit phones
Expand Down Expand Up @@ -53,7 +57,7 @@
margin-left: -1rem;
padding-left: 1rem;

h4 {
h3 {
font-weight: normal;
margin-bottom: 0.1rem;
a {
Expand All @@ -67,7 +71,7 @@
@media (max-width: $screen-md) {
flex-direction: column;
}
h5 {
h3, h4 {
width: 160px;
flex: 0 0 auto;
}
Expand Down
7 changes: 5 additions & 2 deletions packages/typescriptlang-org/src/templates/tsconfigReference.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,12 @@ const TSConfigReferenceTemplateComponent = (props: Props) => {
}

const showCategories = (categories: Category[], sectionName?: string) => {
const CategoryHeading = sectionName ? "h4" : "h3"
return <div className={sectionName ? "tsconfig-quick-nav grouped" : "tsconfig-quick-nav"}>
{sectionName ? <h4><code><a href={`#${sectionName}`}>"{sectionName}"</a></code></h4> : <div />}
{sectionName ? <h3><code><a href={`#${sectionName}`}>"{sectionName}"</a></code></h3> : <div />}
{
categories.map(c => <div className="tsconfig-quick-nav-category" key={c.display}>
<h5 id={`quick-nav-${c.anchor}`}>{c.display}</h5>
<CategoryHeading id={`quick-nav-${c.anchor}`}>{c.display}</CategoryHeading>
<ol aria-labelledby={`quick-nav-${c.anchor}`}>
{c.options.map(o => <li key={o.name}><code><a href={anchor(sectionName, o.anchor)}>{o.anchor}</a>{joiner(c.options, o)}</code></li>)}
</ol>
Expand All @@ -178,6 +179,8 @@ const TSConfigReferenceTemplateComponent = (props: Props) => {
return (
<Layout title={i("tsconfig_title")} description={i("tsconfig_description")} lang={props.pageContext.locale}>

<h1 className="tsconfig-page-title">TSConfig Reference</h1>

<div className={`tsconfig raised main-content-block markdown button ${openInfo ? "open" : "closed"}`} >
<a href="#" onClick={toggleInfoState} aria-expanded={openInfo} role="button">
<h2>
Expand Down
Loading