Tooltip going out of window

[praveen5959]

Hi Team,

When I hover over visualized data in sanddance-explorer , the tooltip is going below the whole visualization area.

[danmarshall]

Thanks for the report Praveen. We are attaching this element to the document.body here:
https://github.com/microsoft/SandDance/blob/master/packages/sanddance/src/tooltip.tsx#L36

Perhaps there's an assumption that absolute positioning will work in this context, but in your case there may be something offsetting this. Can you provide a repro?

Related: #394

[praveen5959]

Hi @danmarshall

I was going through the file reference you provided and wanted to make some changes in sanddance/src/tooltip.tsx , but how to build the repo after these changes locally.

If I run npm run build cmd then the changes are not built.

[danmarshall]

Hi Praveen, are you using npm start ?

[praveen5959]

Hi Dan, no I am building the sanddance-explorer package which I am consuming in another React App.

[danmarshall]

Your other app is not picking up the changes because it has a copy of the .js files from the published version from npm.

The workflow to make changes to SandDance components is:

1. make code changes in your local clone of this repo.
2. test changes with a test harness, e.g. use npm start to run the sample SandDance app locally.
3. create a new git branch in your local clone.
4. push the branch and submit a pull request to this repo.
5. we review your code in the pull request.
6. we merge your pull request.
7. we publish a new version.
8. you npm install this new version in your other project.

Try running npm start to see your changes :)

[praveen5959]

Hi @danmarshall

When I run the app using npm start and load my dataset the tooltips are coming properly.

But when I build the .tgz file of sanddance-explorer package and use it in my React App, the tooltip comes below the canvas area:

[amcdnl]

I would say this is likely related to my ticket: #394

[danmarshall]

PR #493 allows for a custom tooltip provider.