Fix: reference with folder loading - #2133
Merged
Merged
Conversation
A reference like ./Directory/File.json#/components/schema/abc was before read as: refId = abc externalResource = ./Directory Which dropped the file name, which will be fixed by this commit
dldl-cmd
requested review from
MaggieKimani1,
andrueastman,
baywet,
darrelmiller,
gavinbarron,
irvinesunday and
millicentachieng
as code owners
February 6, 2025 16:48
baywet
requested changes
Feb 6, 2025
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
… there will be always a result Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
baywet
approved these changes
Feb 6, 2025
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Member
|
@MaggieKimani1 for final review and merge here please |
MaggieKimani1
enabled auto-merge
February 7, 2025 07:17
MaggieKimani1
approved these changes
Feb 7, 2025
MaggieKimani1
disabled auto-merge
February 7, 2025 07:31
MaggieKimani1
enabled auto-merge
February 7, 2025 07:31
auto-merge was automatically disabled
February 7, 2025 08:43
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reference like ./Directory/File.json#/components/schema/abc was before read as:
refId = abc
externalResource = ./Directory
Which dropped the file name, which will be fixed by this commit
fixes #1674