Draft
Conversation
Agent-Logs-Url: https://github.com/mickamy/sql-tap/sessions/5369e94a-1ada-4774-b2c1-f151125a958f Co-authored-by: mickamy <11856337+mickamy@users.noreply.github.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 30064254 | Triggered | Generic Password | 1bc3958 | proxy/mysql/proxy_test.go | View secret |
| 30064254 | Triggered | Generic Password | 1bc3958 | proxy/mysql/proxy_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…ySQL URL DSN parsing Agent-Logs-Url: https://github.com/mickamy/sql-tap/sessions/5369e94a-1ada-4774-b2c1-f151125a958f Co-authored-by: mickamy <11856337+mickamy@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mickamy/sql-tap/sessions/5369e94a-1ada-4774-b2c1-f151125a958f Co-authored-by: mickamy <11856337+mickamy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix auth error with some passwords in sql-tap
Fix auth errors with complex MySQL passwords
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some passwords triggered
auth error from upstreamwhen connecting through the proxy, even though the same credentials worked in direct clients. The original error message discarded MySQL's actual error, making diagnosis impossible, andDATABASE_URLin URL format (******host:3306/db) was silently broken for the EXPLAIN feature.Changes
proxy/mysql/conn.goerrPacketMsgOffset = 9constant documenting the ERR packet layout (0xFF+ error_code(2) +#+ sqlstate(5))dsn/dsn.gomysqlURLToDriverDSN(): converts a bareuser:pass@host:3306/dbaddress to the go-sql-driver-requireduser:pass@tcp(host:3306)/dbform after stripping themysql://prefix. Previously this caused an immediatesql.Openerror ("default addr for network 'host:3306' unknown"), silently disabling EXPLAIN for users providing standard URL-format DSNs. Handles passwords containing@, unix socket paths, and query parameters correctly.Tests
TestComplexPasswordAuth— proxy auth with the exact password from the issue reportTestCachingSHA2PasswordFullAuth— explicitcaching_sha2_passwordfull-auth path (RSA key exchange, cold cache, non-root user) confirming the proxy relays auth correctly without SSLTestMySQLURLToDriverDSN— unit tests for DSN conversion covering special-char passwords,@-containing passwords, query params, and already-wrapped addresses