Fix default radio.rxgain for Station G2#2134
Merged
liamcottle merged 1 commit intoMar 24, 2026
Merged
Conversation
As @LitBomb pointed out in his [comment](meshcore-dev#2118 (comment)) on meshcore-dev#2118 RX Boosted Gain should not be enabled for the Station G2. This change is a fix for meshcore-dev#2124 to make the default of `radio.rxgain` to be OFF on the Station G2. This restores the pre-1.14.1 behaviour with the only change being the user is now able to change the setting in the CLI.
weebl2000
approved these changes
Mar 23, 2026
Contributor
|
@jeroenvermeulen Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @LitBomb pointed out in his comment on #2118 RX Boosted Gain should not be enabled for the Station G2.
This change is a fix for #2124 to make the default of
radio.rxgainto be OFF on the Station G2.This restores the pre-1.14.1 behaviour with the only change being the user is now able to change the setting in the CLI.