Skip to content

security: gh security recs #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hay-kot merged 13 commits into from
Apr 2, 2024
Merged

security: gh security recs #3368

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
185965e
change ALLOW_SIGNUP to default to false
hay-kot Mar 24, 2024
5c05a3e
add 1.4.0 tag for OIDC docs
hay-kot Mar 24, 2024
7f5e587
new notes on security inline with security/policy review
hay-kot Mar 24, 2024
7f43248
safer transport for external requests
hay-kot Mar 24, 2024
021daee
fix linter errors
hay-kot Mar 24, 2024
42f05ab
docs: Tidy up wording/formatting
boc-the-git Mar 25, 2024
ea35d46
fix request errors
hay-kot Mar 25, 2024
edaee08
whoops
hay-kot Mar 25, 2024
d321dce
fix implementation with std lib
hay-kot Mar 27, 2024
f34b5ee
format
hay-kot Mar 31, 2024
1d116ac
Remove check on netloc_parts. It only includes URL after any @
boc-the-git Apr 1, 2024
4063be8
Merge branch 'mealie-next' into security/gh-security-recs
hay-kot Apr 1, 2024
8fd581f
Merge branch 'mealie-next' into security/gh-security-recs
hay-kot Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mealie/pkgs/safehttp/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ async def handle_async_request(self, request):
netloc = request.url.netloc.decode()
if ":" in netloc: # Either an IP, or a hostname:port combo
netloc_parts = netloc.split(":")
if len(netloc_parts) > 1: # netloc of username:password@hostname:port not supported
Copy link
Copy Markdown
Collaborator

@boc-the-git boc-the-git Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hay-kot see this log.. showing that even when user:pass is included in the url, it was being stripped out before getting to this netloc variable. Thus, the check on parts is irrelevant here.

image

raise InvalidDomainError(f"unsupported request format: {request.url} -> {ip}")

netloc = netloc_parts[0]

Expand Down