Repository navigation
Conversation
added 3 commits
September 29, 2026 21:14
The QA report was recorded while it sat inside the worktree tree during an early --write run. main now ships the isPrivateReport predicate (dot-prefixed *-accept.md files are skipped at the scanner), so a fresh --write drops the stale registration without touching any reviewed source path.
a341a65 added an rmSync(dir, ...) teardown to S2-RH-03b after #86 had already migrated the file's imports to the shared tmp helper (node:fs no longer exports rmSync here), so the suite died with ReferenceError: rmSync is not defined. dir comes from mkTmpDir, so rmTmpDir(dir) is the matching tracked removal.
The test:release-tools registry gate ('test-tmp-leak registry:
KNOWN_PREFIXES covers every prefix ... no bare mkdtemp') flagged the
S3 catalogue tests: both files staged their tmp base with bare
mkdtempSync and cleaned up with ad-hoc rmSync, so the directories
were invisible to the helper's exit-hook sweep (AGENTS.md test
hygiene: every per-test tmp dir goes through helpers/tmp.js).
Route both files through mkTmpDir/rmTmpDir, mirroring the
runtime-host.test.js idiom: module-level tmpBase via mkTmpDir,
per-test children via mkTmpDir(`${label}-`, { parent: tmpBase }),
teardown via rmTmpDir. Behaviour is unchanged — same prefixes, same
isolation, same MINIMAX_DATA_DIR wiring; the dirs are additionally
registered for signal/exit sweep.
Register the two now-visible literal prefixes
(mcode-webui-s3-catalogue-, mcode-webui-s3-fallback-) in
KNOWN_PREFIXES in alphabetical position, as collectActualPrefixes()
requires once the helper calls carry them as literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 main 固有红（三 commit，内容经两条独立修复线交叉验证一致）：
验证（两条独立修复线各自跑全 + 交叉验证一致）
背景：#91/#92 的内容此前已分别 squash 合并（a341a65d / a739fa7），但合并把上述三个固有红一并带进了 main；本 PR 只含修复，不重复功能内容。