Add CLEAR to the TransactionReport.Tag enum (STF-190)#617
Open
Add CLEAR to the TransactionReport.Tag enum (STF-190)#617
CLEAR to the TransactionReport.Tag enum (STF-190)#617Conversation
Part of STF-190. The `clear` tag retracts a previously reported fraud report tag on a transaction, restoring its label to "unknown" (distinct from the positive `NOT_FRAUD` signal). Backend support shipped in STF-15; this adds SDK support. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sets up `mise` for automatic Java + Maven provisioning, matching the pattern already in use in minfraud-api-dotnet and GeoIP2-dotnet. This lets contributors run the full test/lint loop locally without manually installing a JDK or Maven. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the CLEAR tag to the TransactionReport.Tag enum and includes a test case for its serialization. It also introduces mise configuration files for development environment management. A review comment suggests pinning Java and Maven versions in mise.toml to specific versions instead of using latest to ensure environment stability.
Comment on lines
+10
to
+11
| java = "latest" | ||
| maven = "latest" |
There was a problem hiding this comment.
Using latest for tool versions can lead to non-deterministic environments if the lockfile is regenerated or bypassed. Since the project explicitly requires Java 17 (as noted in the CHANGELOG.md), it is safer to specify the major version to ensure the environment remains compatible with the project's requirements.
Suggested change
| java = "latest" | |
| maven = "latest" | |
| java = "17" | |
| maven = "3.9" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLEARto theTransactionReport.Tagenum with amatching javadoc entry. Adds a unit test verifying serialization to
"clear"via the existingtoString()override. Appends a bullet tothe existing unreleased
4.3.0entry inCHANGELOG.md.mise.toml(and generatedmise.lock) socontributors can
mise installto get a working Java + Maventoolchain. Matches the pattern already in
minfraud-api-dotnet/GeoIP2-dotnet. Not STF-190 specific — separate commit for easy review.The
cleartag retracts a previously reported fraud report on a transaction(restoring its label to "unknown", distinct from the positive
NOT_FRAUDsignal). Backend support shipped in STF-15; this adds SDK support per STF-190.
Linear: https://linear.app/maxmind/issue/STF-190
Test plan
mise exec -- mvn test -Dtest=TransactionReportTest— 14 passedmise exec -- mvn checkstyle:check— 0 violations🤖 Generated with Claude Code