Skip to content

Upgrade ruff to 0.16.5 and address new rules #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oschwald wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade ruff to 0.16.5 and address new rules #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bef6d56
Bump ruff to 0.16.5
oschwald Sep 9, 2026
e5cc689
Ignore CPY001 (missing-copyright-notice)
oschwald Sep 9, 2026
836b438
Suppress PLR0917 where a fix would break the public API
oschwald Sep 9, 2026
54fab08
Format Python code blocks in Markdown
oschwald Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,7 @@ When a field returns a date string from the API (e.g., "2025-04-14"):
import datetime

self.network_last_seen = (
datetime.date.fromisoformat(network_last_seen)
if network_last_seen
else None
datetime.date.fromisoformat(network_last_seen) if network_last_seen else None
)
```

Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ ignore = [
# Redundant as the formatter handles missing trailing commas.
"COM812",

# We do not want a copyright header on every file.
"CPY001",

# documenting magic methods
"D105",

Expand Down
4 changes: 2 additions & 2 deletions src/geoip2/webservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class AsyncClient(BaseClient):
_existing_session: aiohttp.ClientSession
_proxy: str | None

def __init__( # noqa: PLR0913
def __init__( # noqa: PLR0913, PLR0917
self,
account_id: int,
license_key: str,
Expand Down Expand Up @@ -460,7 +460,7 @@ class Client(BaseClient):
_session: requests.Session
_proxies: dict[str, str] | None

def __init__( # noqa: PLR0913
def __init__( # noqa: PLR0913, PLR0917
self,
account_id: int,
license_key: str,
Expand Down
38 changes: 19 additions & 19 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading