Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[build] Mixed npm/mason output in clean build - #5322

Merged
brunoabinader merged 1 commit into
masterfrom
brunoabinader-node-modules-non-parallel
Jun 12, 2016
Merged

[build] Mixed npm/mason output in clean build#5322
brunoabinader merged 1 commit into
masterfrom
brunoabinader-node-modules-non-parallel

Conversation

@brunoabinader

Copy link
Copy Markdown
Contributor

A clean build e.g. make qt-app is causing mixed npm/mason output:

./configure platform/qt/scripts/configure.sh build/qt-osx-x86_64/config.gypi osx x86_64
npm update # Install dependencies but don't run our own install script.
* Using Python 2.7.10
* Installed system-provided Qt 5.6.0
normalizeTree → correctMk ▌ ╢░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░╟
normalizeTree → addLocalD ▐ ╢░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░╟
* Installed binary package at /Users/bruno/work/mapbox-gl-native/mason_packages/headers/unique_resource/dev
* Downloading binary package headers/protozero/1.3.0.tar.gz...
* Installed binary package at /Users/bruno/work/mapbox-gl-native/mason_packages/headers/protozero/1.3.0
fetchMetadata → 304       ▀ ╢████████████████████████████████████░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░╟
...

By adding .NOTPARALLEL: node_modules, npm update will be called after mason setup. While this might have a small impact in build times on clean environments e.g. build bots, output is cleaner.

👀 @jfirebaugh @kkaefer

@brunoabinader

Copy link
Copy Markdown
Contributor Author

This is a requirement for #5325 - otherwise make compdb errors before mapbox-gl-shaders is installed due to race condition.

@brunoabinader
brunoabinader merged commit 62d355a into master Jun 12, 2016
@brunoabinader
brunoabinader deleted the brunoabinader-node-modules-non-parallel branch June 12, 2016 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant