Bump WordPress Tested up to version 7.0#205
Conversation
QA Update ❌Issue 1: When saving the settings, the settings page turns blank for a few seconds, while the “settings saved” notice appears at the top. After a few seconds, the page reloads and displays normally again. Steps to Reproduce:
Expected Result:
Screen.Recording.2026-03-27.at.1.43.24.PM.movcc @iamdharmesh |
|
@iamdharmesh this appears to be awaiting your review. It would be good to take a look and move this forward to the next step. Thanks! |
There was a problem hiding this comment.
Pull request overview
Updates plugin compatibility metadata for upcoming WordPress 7.0 and aligns tooling/CI with the new minimum supported WordPress version. In addition, this PR introduces a small refactor for admin notice rendering and a minor admin UI styling adjustment.
Changes:
- Bump “Tested up to” to WordPress 7.0 and minimum supported WordPress version to 6.6 (readme + plugin header + PHPCS + CI matrix).
- Introduce
Mailchimp_Admin_Noticesfor centralized admin notice rendering and convert legacy notice helpers into wrappers. - Adjust admin radio button checked styling in
admin.css.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updates “Tested up to” to 7.0. |
| phpcs.xml | Raises minimum_supported_wp_version to 6.6. |
| mailchimp.php | Raises plugin header “Requires at least” to 6.6 and loads new admin notices class. |
| includes/class-mailchimp-admin.php | Initializes the new admin notices system during admin bootstrap. |
| includes/admin/class-mailchimp-admin-notices.php | Adds a new centralized admin notice queue/renderer. |
| includes/admin/admin-notices.php | Converts legacy notice functions into wrappers around the new class. |
| assets/css/admin.css | Tweaks checked radio background styling. |
| .github/workflows/e2e.yml | Updates CI “WP minimum” to run against WordPress 6.6. |
Comments suppressed due to low confidence (2)
includes/admin/class-mailchimp-admin-notices.php:116
- Because the allowed HTML for links permits
target, it should also permitrel(and ideally ensurenoopener noreferrerwhentarget="_blank"is used). As-is, any providedrelattribute will be stripped bywp_kses, making it harder to avoid reverse-tabnabbing issues.
$allowed_html = array(
'a' => array(
'href' => array(),
'title' => array(),
'target' => array(),
),
'strong' => array(),
includes/admin/admin-notices.php:30
- This docblock also uses the placeholder "@SInCE x.x.x". Please update it to the actual version (or remove the placeholder) before merge/release.
* Display error admin notice.
* This function is now a wrapper around the Mailchimp_Admin_Notices class, will be deprecated in future versions. Use that class instead.
*
* @since 1.7.0
* @since x.x.x - Moved notice rendering to class-mailchimp-admin-notices.php
*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of the Change
Closes #202
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: