lb4 repository,model,controller commands generate artifacts with 'lint' issues

[emonddr]

I tried running : npm run test

after creating the artifacts from the Todo tutorial, and the linting after the tests fail.

I did a comparison of the generated files, and the files after npm run lint:fix and these are the differences I found:

Controller:

Repository:

Model:

Steps to reproduce

Current Behavior

Expected Behavior

Link to reproduction sandbox

Additional information

Related Issues

See Reporting Issues for more tips on writing good issues

Acceptance Criteria

• Create the Todo application with the lb4 commands, and then ensure the npm run lint completes without error.
• fix templates ( might need to update snapshots test as well)
• add solutions to fix the lint error in docs

[raymondfeng]

Use --format flag. See standard options at https://loopback.io/doc/en/lb4/Application-generator.html#options.

[bajtos]

Use --format flag. See standard options at https://loopback.io/doc/en/lb4/Application-generator.html#options.

Personally, I consider that approach as a workaround. We should strive to emit code that passes our linter rules.

I think the issue pointed out by @emonddr should be easy to fix.

If we think --format is the solution that more people should use, then let's find a way how to enable that option by default. (But that's out of scope of this issue.)

[dhmlau]

@emonddr, could you please add the acceptance criteria? Thanks.

[jannyHou]

I am on the latest cli @loopback/cli@1.27.0, the created todo example (lb4 example --> select todo) already fixes the lint errors in CONTROLLER and MODEL:

• model:
  
• controller:
  

The REPOSITORY has the correct code: changing

constructor(@inject('datasources.db') dataSource: juggler.DataSource) {
    super(Todo, dataSource);
  }

to

constructor(
  @inject('datasources.db') dataSource: juggler.DataSource
) {
    super(Todo, dataSource);
  }

results in lint error, so we should stay with the current behaviour.

There is a new lint error found in the controller file, it's already fixed in the latest master branch, so a new release will get rid of it:

[jannyHou]

I will wait for a new release before closing this story.