Skip to content

Mask by list of values#404

Merged
metasim merged 9 commits into
locationtech:developfrom
s22s:feature/local_is_in
Nov 10, 2019
Merged

Mask by list of values#404
metasim merged 9 commits into
locationtech:developfrom
s22s:feature/local_is_in

Conversation

@vpipkt

@vpipkt vpipkt commented Nov 5, 2019

Copy link
Copy Markdown
Member

And other related masking enhancements.

Closes #403

Refactor docs to address #384 since we are adding some new related functionality as well.

Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
@vpipkt

vpipkt commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

@metasim one thing i am not sure of is how to expose the rf_mask_by_values in the SQL api since i have not defined a separate Expression for it.

@vpipkt vpipkt requested a review from metasim November 6, 2019 14:06
…t tests

Signed-off-by: Jason T. Brown <jason@astraea.earth>

@metasim metasim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work!! :shipit:

vpipkt and others added 4 commits November 8, 2019 15:02
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Removed inverse flag from rf_mask_by_values before committing to an approach with it.
@metasim metasim merged commit ecf5748 into locationtech:develop Nov 10, 2019
@vpipkt

vpipkt commented Nov 11, 2019

Copy link
Copy Markdown
Member Author

@metasim thanks a bunch for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve masking to allow for set of values.

2 participants