Document and improve use of CellType in rasterfunctions args#271
Merged
Conversation
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Member
Author
|
To close #238 |
metasim
approved these changes
Aug 9, 2019
| ``` | ||
| Tile rf_make_zeros_tile(Int tile_columns, Int tile_rows, String cell_type_name) | ||
| Tile rf_make_zeros_tile(Int tile_columns, Int tile_rows, [CellType cell_type]) | ||
| Tile rf_make_zeros_tile(Int tile_columns, Int tile_rows, [String cell_type_name]) |
Member
There was a problem hiding this comment.
@vpipkt Sometime before 1.0, we should change these signatures to use the var: Type ordering, as that's what type hints in Python 3.7 use (along with Scala).
That said, really want to get this stuff generated by Sphinx.
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Member
Author
|
@metasim the function to get celltype had already been refactored, this PR was just clean up https://github.com/locationtech/rasterframes/pull/271/files#diff-7a654590ae01cfdf224abac0aa84caeeL211-L212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note the more careful parsing of user defined nodata.
It's tagged 0.8.0 because it is a small fry but we can easily push it off.