WIP: Python test_sql refactor all comparisons to inside SQL#225
Closed
vpipkt wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Member
Author
|
Well that did not work https://travis-ci.org/locationtech/rasterframes/builds/566080081#L4979-L5013 |
Member
|
Added https://travis-ci.org/locationtech/rasterframes/builds/566536333#L5122-L5133 Looks like |
Member
Author
|
Going totally out on a limb. The other odd thing is we now get warnings on pyrsistent python library install. Maybe bump version back to 0.15.3? Note 0.15.4 released Jul 27. I have no idea if/how that might affect these tests. Will try it out and we can back it out if it doesn't help. |
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Member
Author
|
Hmm now no Travis run on the PR 🤦♂ |
vpipkt
commented
Aug 2, 2019
| "ipykernel==4.8.0", | ||
| 'Pweave==0.30.3' | ||
| 'Pweave==0.30.3', | ||
| 'pyrsistent==0.15.3', |
Member
Author
There was a problem hiding this comment.
Probably needs another look if this is needed.
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping that this will pass Travis build.