Skip to content

WIP: Python test_sql refactor all comparisons to inside SQL#225

Closed
vpipkt wants to merge 6 commits into
locationtech:developfrom
s22s:fix/test_sql_fails_travis
Closed

WIP: Python test_sql refactor all comparisons to inside SQL#225
vpipkt wants to merge 6 commits into
locationtech:developfrom
s22s:fix/test_sql_fails_travis

Conversation

@vpipkt

@vpipkt vpipkt commented Jul 31, 2019

Copy link
Copy Markdown
Member

Hoping that this will pass Travis build.

Signed-off-by: Jason T. Brown <jason@astraea.earth>
@vpipkt

vpipkt commented Jul 31, 2019

Copy link
Copy Markdown
Member Author

@vpipkt vpipkt changed the title Python test_sql refactor all comparisons to inside SQL WIP: Python test_sql refactor all comparisons to inside SQL Jul 31, 2019
@metasim

metasim commented Aug 1, 2019

Copy link
Copy Markdown
Member

Added show to see what the numbers are:

https://travis-ci.org/locationtech/rasterframes/builds/566536333#L5122-L5133

+------------------+------------------+------------------+------------------+------------------+
|base              |plus_one          |minus_one         |double            |half              |
+------------------+------------------+------------------+------------------+------------------+
|10573.227770833333|10465.225422680413|10572.227770833333|21146.455541666666|5286.613885416667 |
|9672.139422680413 |9673.139422680413 |9671.139422680413 |19344.278845360826|4836.069711340207 |
|10122.969770833333|10019.60925773196 |10121.969770833333|20245.939541666667|5061.484885416667 |
|9912.923030927835 |9913.923030927835 |9911.923030927835 |19825.84606185567 |4956.461515463918 |
|10606.11498969072 |10607.11498969072 |10605.11498969072 |21212.22997938144 |5303.05749484536  |
|10488.786144329897|10489.786144329897|10487.786144329897|20977.572288659794|5244.3930721649485|
|10305.663113402063|10306.663113402063|10304.663113402063|20611.326226804125|5152.831556701031 |
|9605.92806185567  |9606.92806185567  |9604.92806185567  |19211.85612371134 |4802.964030927835 |
+------------------+------------------+------------------+------------------+------------------+

Looks like plus_one is whacked.

@vpipkt

vpipkt commented Aug 2, 2019

Copy link
Copy Markdown
Member Author

Going totally out on a limb. The other odd thing is we now get warnings on pyrsistent python library install. Maybe bump version back to 0.15.3? Note 0.15.4 released Jul 27. I have no idea if/how that might affect these tests. Will try it out and we can back it out if it doesn't help.

Signed-off-by: Jason T. Brown <jason@astraea.earth>
@vpipkt

vpipkt commented Aug 2, 2019

Copy link
Copy Markdown
Member Author

Hmm now no Travis run on the PR 🤦‍♂

@metasim metasim changed the title WIP: Python test_sql refactor all comparisons to inside SQL Python test_sql refactor all comparisons to inside SQL Aug 2, 2019
Comment thread pyrasterframes/src/main/python/setup.py Outdated
"ipykernel==4.8.0",
'Pweave==0.30.3'
'Pweave==0.30.3',
'pyrsistent==0.15.3',

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs another look if this is needed.

vpipkt added 2 commits August 2, 2019 13:02
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
@vpipkt vpipkt changed the title Python test_sql refactor all comparisons to inside SQL WIP: Python test_sql refactor all comparisons to inside SQL Aug 2, 2019
@vpipkt vpipkt closed this Aug 2, 2019
@vpipkt
vpipkt deleted the fix/test_sql_fails_travis branch August 7, 2019 21:01
@vpipkt
vpipkt restored the fix/test_sql_fails_travis branch August 7, 2019 21:02
@vpipkt
vpipkt deleted the fix/test_sql_fails_travis branch August 7, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants