Ignore stale Rancher Desktop during detection - #456
Merged
gtsiolis merged 1 commit intoAug 13, 2026
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
gtsiolis
added
semver: patch
docs: skip
Member
Author
|
@skyrpex could you take a look since you added this in #399. Cc @anisaoshafi |
gtsiolis
marked this pull request as ready for review
August 13, 2026 10:49
skyrpex
approved these changes
Aug 13, 2026
Contributor
|
LGTM, honestly a much better heuristic 馃憤 |
Member
Author
|
Thanks for taking a look, @skyrpex! 馃檹 |
gtsiolis
deleted the
pro-374-ignore-stale-rancher-desktop-state-during-runtime-detection
branch
August 13, 2026 11:48
gtsiolis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When Docker is unavailable, lstk treats any existing
~/.rddirectory as evidence that Rancher Desktop is installed. Rancher Desktop leaves this directory and broken CLI symlinks behind after uninstalling, which causes lstk to recommend an unusablerdctl startaction.Here's what I was seeing on start.
Solution
Use a resolvable
rdctlexecutable onPATHas fallback installation evidence instead of the Rancher state directory alone. Configured Rancher Desktop socket detection remains unchanged.Add regression coverage for both an installed-but-stopped Rancher Desktop and stale
~/.rdstate after uninstalling.Docs
No documentation changes are needed. This corrects a runtime detection false-positive without changing the documented container-runtime workflow.
Review
Self-merge candidate: this is a small, focused detection fix with regression coverage and no new user-facing behavior. A human review is optional unless the team wants to revisit the existing cross-platform assumption that Rancher Desktop installs
rdctlonPATH.Closes PRO-374
Co-Authored-By: Claude noreply@anthropic.com