Fix integration test compile break left by PTY migration

[skyrpex]

Motivation

origin/main's test/integration module does not compile since #444: that PR removed the bytes, runtime, and github.com/creack/pty imports from license_test.go and migrated TestLicenseRejectionOffersReloginAndRetries to the xpty helpers, but left TestLicenseRejectionEscDeclineShowsManualSteps still calling pty.Start / runtime.GOOS / bytes.Contains — undefined identifiers, so the integration lint/test CI jobs on main are red. The same squash also landed five files that are not gofmt-clean.

How this got past CI: #444's last commit was pushed before #449 merged, and #449 added TestLicenseRejectionEscDeclineShowsManualSteps — a new test using exactly the imports #444 was removing. The two changes touch different regions of license_test.go, so the squash merged cleanly with no textual conflict, and the branch was merged without rebasing or re-running CI — each PR was green individually, but nothing ever compiled the combination until it landed on main. (Requiring up-to-date branches, or a merge queue, would prevent this class of breakage.)

Solution

Finish the #444 migration for the one missed test: TestLicenseRejectionEscDeclineShowsManualSteps now uses startLstkInPTY/waitForOutputTimeout/write/wait exactly like its already-migrated sibling, the Windows PTY skip is dropped (the helpers are ConPTY-capable; requireDocker still gates it on Windows CI), and the transcript-on-failure logging is kept via p.output(). Also gofmt -w on the five unformatted files (env/env.go, logout_test.go, logs_test.go, status_test.go, volume_test.go) — whitespace only.

Docs

Nothing to document: test-only compile fix and formatting, no user-facing behavior change.

Review

Self-merge candidate: restores compilation with the exact helper pattern #444 already established (and that the sibling test uses); no behavior change beyond re-enabling the test on the platforms it already targeted. Verified with go vet, gofmt, and golangci-lint (0 issues) in the test/integration module.

Co-Authored-By: Claude noreply@anthropic.com

🤖 Generated with Claude Code

[claude]

LGTM 🎉 — finishes the #444 xpty-helper migration for the one missed test, and I confirmed the test/integration module now compiles (go vet ./... → 0) and is gofmt-clean (gofmt -l → empty), with no behavior change beyond re-enabling the test where it already ran. @skyrpex

Automated review on behalf of @gtsiolis.

---

Generated by Claude Code