agent simulation: audio impairments on the create request - #1723
Merged
Conversation
🦋 Changeset detectedLatest commit: b9d3158 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Aug 20, 2026
theomonnom
approved these changes
Aug 20, 2026
u9g
force-pushed
the
jason/simulate-audio-impairments
branch
from
August 24, 2026 15:11
f901923 to
b9d3158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
background_noise,low_quality_microphone, andpacket_losstoSimulationRun.Create.Request, so an audio simulation run can impair the simulated user's audio.The CLI side is livekit/livekit-cli#943, which turns the
--audioflag into anaudiosubcommand that sends them:Nothing consumes the fields yet: agent-service reads only
req.GetMode()today, and the simulator will likely need them carried onSimulationDispatchas well.Overlap worth flagging: the unmerged
agent-simulation/scenario-environment-backchannelbranch proposes a richerScenarioGroup.Environmentfor the same problem space (background_noiseas a string, plusaudio_events,audio_degradations,backchannel). If that shape is where this is headed, I'm happy to fold these three booleans into it instead.