Tech/lfx 1904 notes clean up#2741
Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request involves the comprehensive removal of note-related functionality across multiple frontend files. The changes eliminate components, services, and type definitions associated with creating, editing, and displaying notes for contributors. By removing files such as Changes
Possibly related PRs
Poem
Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/modules/contributor/pages/contributor-details.page.vue (1)
146-146: LGTM! Consider extracting the tab name to a constant.The scroll control logic correctly handles infinite scroll for activities after removing notes. Consider extracting 'activities' to a constant to avoid magic strings:
+const ACTIVITIES_TAB = 'activities'; + const controlScroll = (e) => { if (e.target.scrollTop + e.target.clientHeight >= e.target.scrollHeight - 10) { - if (tabs.value === 'activities') { + if (tabs.value === ACTIVITIES_TAB) { activities.value.loadMore(); } } };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
frontend/src/modules/contributor/components/details/contributor-details-notes.vue(0 hunks)frontend/src/modules/contributor/pages/contributor-details.page.vue(2 hunks)frontend/src/modules/notes/components/note-dropdown.vue(0 hunks)frontend/src/modules/notes/components/note-editor.vue(0 hunks)frontend/src/modules/notes/components/note-item.vue(0 hunks)frontend/src/modules/notes/note-service.js(0 hunks)frontend/src/modules/notes/types/Note.ts(0 hunks)
💤 Files with no reviewable changes (6)
- frontend/src/modules/notes/components/note-dropdown.vue
- frontend/src/modules/notes/components/note-editor.vue
- frontend/src/modules/notes/types/Note.ts
- frontend/src/modules/contributor/components/details/contributor-details-notes.vue
- frontend/src/modules/notes/components/note-item.vue
- frontend/src/modules/notes/note-service.js
🔇 Additional comments (2)
frontend/src/modules/contributor/pages/contributor-details.page.vue (2)
78-78: LGTM! Clean tab handling.The simplified conditional rendering with
v-elsecorrectly handles the binary tab state (overview/activities) after removing the notes tab.
Line range hint
1-179: Verified complete removal of notes functionality.The cleanup is thorough - all notes-related components, imports, variables, and logic have been successfully removed from the file.
gaspergrom
left a comment
gaspergrom
left a comment
There was a problem hiding this comment.
Notes are still present in permissions and events
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
2 participants
Changes proposed ✍️
What
Removed notes module in the frontend and it's usage on the contributor page
Why
Code clean up
Ticket: LFX-1904
Checklist ✅
Feature,Improvement, orBug.Summary by CodeRabbit
Release Notes
Removed Features
Impacted Components
User Impact