Support signing BOLT 12 messages in NodeSigner#2432
Merged
valentinewallace merged 16 commits intoAug 22, 2023
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOLT 12 messages need to be signed in the following scenarios:
InvoiceRequestafter scanning anOffer,Invoiceafter scanning aRefund, andInvoicewhen handling anInvoiceRequest.Extend the
NodeSignertrait to support signing BOLT 12 messages such that it can be used in these contexts. The method could be used then in anOffersMessageHandlerwhen keys aren't derived from the offer or payer metadata.Taken from #2371.