Skip to content

Rescan the wallet_rescan_from_height block - #1069

Open
tankyleo wants to merge 1 commit into
lightningdevkit:mainfrom
tankyleo:2026-08-rescan-height-inclusive
Open

Rescan the wallet_rescan_from_height block#1069
tankyleo wants to merge 1 commit into
lightningdevkit:mainfrom
tankyleo:2026-08-rescan-height-inclusive

Conversation

@tankyleo

@tankyleo tankyleo commented Aug 26, 2026

Copy link
Copy Markdown
Contributor 
    Rescan the `wallet_rescan_from_height` block

    It is surprising to have BDK rescan from one block above the given
    `wallet_rescan_from_height` block. So we tweak things to have the block
    height that the user gives us included in the rescan.

    Co-Authored-By: HAL 9000

@ldk-reviews-bot

ldk-reviews-bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo
tankyleo requested a review from benthecarman August 26, 2026 00:04
@tankyleo tankyleo mentioned this pull request Aug 26, 2026
Open
benthecarman
benthecarman previously approved these changes Aug 26, 2026
View reviewed changes

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tankyleo
tankyleo force-pushed the 2026-08-rescan-height-inclusive branch from f23a8f7 to 18ee061 Compare August 26, 2026 23:40
@tankyleo
Rescan the wallet_rescan_from_height block
94b3ada 
It is surprising to have BDK rescan from one block above the given
`wallet_rescan_from_height` block. So we tweak things to have the block
height that the user gives us included in the rescan.

Co-Authored-By: HAL 9000
@tankyleo
tankyleo force-pushed the 2026-08-rescan-height-inclusive branch from 18ee061 to 94b3ada Compare August 27, 2026 00:10
@tankyleo

tankyleo commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry for the churn ben, making sure the test actually keeps testing the previous case, which is to pick up transactions confirmed a few blocks after the rescan height.

@tankyleo
tankyleo requested a review from benthecarman August 27, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tankyleo @ldk-reviews-bot @benthecarman