LPS-147076

[mbowerman]

Ticket: LPS-147076

Patched third-party org.apache.velocity .jar file with changes from apache/velocity-engine#16 to resolve CVE-2020-13936.

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:relevant
•     ci:test:sf

[liferay-continuous-integration]

❌ ci:test:sf - 0 out of 1 jobs passed in 16 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6e4f802fa12f983f6be9d199184e157ebbe262be

Sender Branch:

Branch Name: LPS-147076
Branch GIT ID: 8ff3a50efcef1e377c0dd1ccae04b5006e20d812

0 out of 1jobs PASSED

1 Failed Jobs:

• test-portal-source-format

For more details click here.

     [java] java.lang.Exception: Found 10 formatting issues:
     [java] 1: Missing copyright, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/copyright_check.markdown: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java (SourceCheck:CopyrightCheck)
     [java] 2: Private non-static field 'badClasses' must match pattern '^_[a-z0-9][_a-zA-Z0-9]*\$', see https://checkstyle.sourceforge.io/config_naming.html#MemberName: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java 40 (Checkstyle:MemberNameCheck)
     [java] 3: Private non-static field 'badPackages' must match pattern '^_[a-z0-9][_a-zA-Z0-9]*\$', see https://checkstyle.sourceforge.io/config_naming.html#MemberName: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java 41 (Checkstyle:MemberNameCheck)
     [java] 4: Parameterize the generic type for 'java.lang.Class, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/generic_type_check.markdown: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java 61 (Checkstyle:GenericTypeCheck)
     [java] 5: Parameterize the generic type for 'java.lang.Class, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/generic_type_check.markdown: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java 88 (Checkstyle:GenericTypeCheck)
     [java] 6: Missing parentheses around the left hand side argument of the '&&' operator: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java 93 (Checkstyle:MissingParenthesesCheck)
     [java] 7: There should be an empty line after line '137', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/check/missing_empty_line_check.markdown: ./modules/third-party/org-apache-velocity/src/main/java/org/apache/velocity/util/introspection/SecureIntrospectorImpl.java 137 (Checkstyle:MissingEmptyLineCheck)

[liferay-continuous-integration]

Jenkins Build:test-portal-source-format#3179

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-core-infra#1678

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - mbowerman > liferay-core-infra - PR#1678 - 2022-09-12[11:53:22]

Testray Importer:publish-testray-report#11624

[liferay-continuous-integration]

❌ ci:test:relevant - 0 out of 1 jobs passed in 23 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6e4f802fa12f983f6be9d199184e157ebbe262be

Upstream Comparison:

Branch GIT ID: 47bba8a43f9b66d559f3caf301b6fc57275919f0
Jenkins Build URL: EE Development Acceptance (master) - 3791 - 2022-09-12[05:13:01]

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

• test-portal-acceptance-pullrequest(master)

For more details click here.

---

Failures unique to this pull:

1. test-portal-acceptance-pullrequest(master)

   Job Results:

   0 Jobs Passed.
   1 Job Failed.

        [exec] > Task :apps:portal-template:portal-template-velocity:compileJava FAILED
        [exec] 
        [exec] > Task :apps:portal-vulcan:portal-vulcan-impl:compileJava
        [exec] 
        [exec] > Task :apps:portal-template:portal-template-react-renderer-impl:packageRunBuild
        [exec] Using pre-existing NODE_ENV: "test"
        [exec] Browserslist: caniuse-lite is outdated. Please run:
        [exec] npx browserslist@latest --update-db
        [exec] 
        [exec] Why you should do it regularly:
        [exec] https://github.com/browserslist/browserslist#browsers-data-updating
        [exec] Successfully compiled 2 files with Babel.
        [exec] Bundling took 98ms
        [exec] Minification summary:
        [exec]   Files processed:   2
        [exec]   Files with errors: 0
        [exec]   Before size:       2102
        [exec]   After size:        766
        [exec]   Delta:             1336
        [exec]   Elapsed:           0.12
        [exec] BUILD SASS: No scss files found.
        [exec] Received 0
        [exec] Done in 2.87s.
        [exec] 
        [exec] > Task :apps:portal-search:portal-search-web:packageRunBuild
        [exec] Bundling took 35s
        [exec] Minification summary:
        [exec]   Files processed:   755
        [exec]   Files with errors: 302
        [exec]   Before size:       5668087
        [exec]   After size:        3073471
        [exec]   Delta:             2594616
        [exec]   Elapsed:           10.35
        [exec] BUILD SASS: Built build/node/packageRunBuild/resources/.sass-cache/css/main.css
        [exec] Received 0
        [exec] Done in 47.69s.
        [exec] Gradle build finished at 2022-09-12 19:14:59.287.
        [exec] 3871 actionable tasks: 3812 executed, 59 up-to-date
        [exec] 
        [exec] 
        [exec] FAILURE: Build failed with an exception.
        [exec] 
        [exec] * What went wrong:
        [exec] Execution failed for task ':apps:portal-template:portal-template-velocity:compileJava'.
        [exec] > Could not resolve all files for configuration ':apps:portal-template:portal-template-velocity:compileClasspath'.
        [exec]    > Could not find com.liferay:org.apache.velocity:1.6.4-LIFERAY-PATCHED-2.
        [exec]      Searched in the following locations:
        [exec]        - file:/opt/dev/projects/github/liferay-portal/.m2/com/liferay/org.apache.velocity/1.6.4-LIFERAY-PATCHED-2/org.apache.velocity-1.6.4-LIFERAY-PATCHED-2.pom

For upstream results, click here.

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

[liferay-continuous-integration]

Jenkins Build:test-portal-acceptance-pullrequest(master)#3623

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-core-infra#1678

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - mbowerman > liferay-core-infra - PR#1678 - 2022-09-12[11:53:17]

Testray Importer:publish-testray-report#8276

[mbowerman]

Re-sent here: #1679