Remove usage of optional arguments to public methods #779 - #810
Closed
JPaulDuncan wants to merge 4 commits into
Closed
Remove usage of optional arguments to public methods #779#810JPaulDuncan wants to merge 4 commits into
JPaulDuncan wants to merge 4 commits into
Conversation
Member
There was a problem hiding this comment.
Original comment is still valid - options is not required.
Member
|
I agree with @nulltoken (from #779 (comment)):
The PR also includes a bunch of reformatting that distracts from the core change. |
Contributor
Author
|
Fracking Resharper! |
Contributor
Author
|
Christ. |
Member
|
@JPaulDuncan Hey! You don't need to close the PR to get it fixed. Just update locally your branch, (force) push and tada.... the PR gets automatically updated! However, for this to work, you'll have it to reopen it, though 😉 |
Member
|
Fix #779 |
Member
There was a problem hiding this comment.
Could you please remove this declaration from IRepository?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the IRepository.cs and Repository.cs files to remove the optional parameters from the various method signatures. This will help address potential versioning issues.