Makes RemoteUpdater disposable so remotehandle can be used throughout an... - #807
Merged
nulltoken merged 1 commit intoSep 1, 2014
Conversation
Member
|
Wow! You're fast! And this looks very clean. Just one nitpick, as far as I can see. Can you please amend your commit so that the first line of the commit message is 50 chars or less? We've found that this was making reviewing commit logs a more easily task. There are tons of articles on that topic, but this one sums it up pretty well. |
Contributor
Author
|
Yes, of course. Bad habit :-/ |
Contributor
Author
|
Commit message is now updated |
Member
|
Isn't the RemoteUpdater used anywhere in tests? |
Member
Member
|
Hole in one! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...d released upon disposal.
PR for #804
@nulltoken let me know if this is what you had in mind. Thanks!