401 Clone Bug in 0.19

[BoasE]

Perhaps this is an reentry of : #529

After upgrading from 0.17 to 0.19 i got this bug again. anyoneelse? (PS only when i use libgit inside a MVC Application not from a console)

I can simple reproducei t.

Create a new ASP MVC 4.5 Project. Add nuget reference to current libgit package (0.19) then extend a controller like HomeController with the following code

  public async Task<ActionResult> Index()
        {


            string myRepo = ; <- Place your reponame here
            string myLocalPath = <- PLace yoru local path here

            Credentials credentials = new UsernamePasswordCredentials()
            {
                Username = "User",
                Password = "PW!"
            };

            try
            {
                CloneOptions options = new CloneOptions { IsBare = false, Credentials = credentials };
                Repository.Clone(myRepo, myLocalPath, options);
            }
            catch (Exception err)
            {
                if (err != null)
                { }
            }
            return View();
        }

i you give me your mail i could also mail you the project.

If i do the same thing with 0.17 everything works fine.

[nulltoken]

Hmm... Indeed I can repro this issue.
With the following error message: Request failed with status code: 401

and stacktrace

at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
at LibGit2Sharp.Core.Ensure.ZeroResult(Int32 result)
at LibGit2Sharp.Core.Proxy.git_clone(String url, String workdir, GitCloneOptions& opts)
at LibGit2Sharp.Repository.Clone(String sourceUrl, String workdirPath, CloneOptions options)
at MvcApplication1.Controllers.HomeController.Index() in c:\TEMP\MvcApplication1\MvcApplication1\Controllers\HomeController.cs:line 39

using the following method

 public ActionResult Index()
  {

      var s = Repository.Version;
      string myRepo = "https://libgit2@bitbucket.org/libgit2/testgitrepository.git";
      string myLocalPath = Path.Combine(Path.GetTempPath(), "lg2s" + Guid.NewGuid());

    Credentials credentials = new UsernamePasswordCredentials()
    {
        Username = "libgit3",
        Password = "libgit3"
    };

    try
    {
        CloneOptions options = new CloneOptions { IsBare = false, Credentials = credentials };
        Repository.Clone(myRepo, myLocalPath, options);
    }
    catch (Exception err)
    {
        if (err != null)
        { }
    }
    return View();
}

Which is very surprising as this test pass

[Theory]
[InlineData("https://libgit2@bitbucket.org/libgit2/testgitrepository.git", "libgit3", "libgit3")]
public void CanCloneFromBBWithCredentials(string url, string user, string pass)
{
    var scd = BuildSelfCleaningDirectory();

    string clonedRepoPath = Repository.Clone(url, scd.DirectoryPath, new CloneOptions() {
        CredentialsProvider = (_url, _user, _cred) => new UsernamePasswordCredentials {
            Username = user,
            Password = pass,
        }
    });

/cc @ethomson @jamill @carlosmn Thoughts?

[nulltoken]

/cc @carlosmn

[BoasE]

I assume it is related to the asp mvc enrionment. In console application it works. CanCloneFromBBWithCredentials doesn't run in the web envrionment does it ? Also it should be a change that has happend after 0.17

[carlosmn]

The environment really shouldn't change anything wrt to this (or at all). I saw this when I was testing something different a while back, where Credentials wasn't being properly converted into a provider.

Since that's just there because it's what used to be there, could you try using the CredentialsProvider, which is the the "real" method for getting the credentials through?

[nulltoken]

Since that's just there because it's what used to be there, could you try using the CredentialsProvider, which is the the "real" method for getting the credentials through?

Already done that. Doesn't work either

The code below also returns a 401

public ActionResult Index()
{

    var s = Repository.Version;
    string myRepo = "https://libgit2@bitbucket.org/libgit2/testgitrepository.git";
    string myLocalPath = Path.Combine(Path.GetTempPath(), "lg2s" + Guid.NewGuid());

    Credentials credentials = new UsernamePasswordCredentials()
    {
        Username = "libgit3",
        Password = "libgit3"
    };

    try
    {
        CloneOptions options = new CloneOptions { IsBare = false, CredentialsProvider = (_url, _user, _cred) => credentials };
        Repository.Clone(myRepo, myLocalPath, options);
    }
    catch (Exception err)
    {
        if (err != null)
        { }
    }
    return View();
}

[carlosmn]

A network dump of the conversation between the server and libgit2 would go a long way at this point, via something like Fiddler e.g. to try to see if we're misidentifying the error, since it seems to fail to work on asp.net on what I'm assuming is the same machine.

[BoasE]

As i tested it some days ago i couldn't see anything in fiddler. @nulltoken can you confirm this? Could you make a fiddler log ?

[nulltoken]

Hmmm. I can't make it fail again (Tested against BitBucket and GitHub)

@Gentlehag Can you still make it fail? If that's the case, what git hoster are you testing against?

[BoasE]

Yeah here it still fails. USing MVC and a non empty github repository

[BoasE]

just recognized that today not all tests are failing.

the version with CredentialsProvider succeeds the others not.

But i don't feel comfortable with that because the test with the provider did fail on Friday and i didn't change anything. With the oldversion everything worked fine.

[nulltoken]

non empty github repository

@Gentlehag A private one? Using oAuth token?

the version with CredentialsProvider succeeds the others not.

So using CredentialsProvider you can succesfully clone but using the obsolete Credentials parameter that fails?

But i don't feel comfortable with that because the test with the provider did fail on Friday and i didn't change anything. With the oldversion everything worked fine.

I understand. However, the LibGit2Sharp code you're relying on didn't change. I can think of two options:

• A change at the GitHub level
• Race concurrency somewhere

[BoasE]

It was a private repository and i accessed it with username and password credentials

Yes currently it fails using the old api and succeeds with the new api.

Do you think it will be reliable working with the current api?

[nulltoken]

Yes currently it fails using the old api and succeeds with the new api.

Just to be sure, what you're seeing is the following?

• Succeeds when using the Credentials setter in v0.17
• Fails when using the Credentials in v0.19
• Succeeds when using the CredentialsProvider in v0.19

Do you think it will be reliable working with the current api?

Credentials has already been dropped from the development branch. It won't be available any more in v0.20. So, yes, CredentialsProvider is the road forward. FWIW, there's at least on Clone() test that leverages it in the CloneFixture.cs test suite. This test passes flawlessly.

[BoasE]

yes the 3 statements are right.

ok i changed my code to the provider i think this can be closed (and hoping that it want appear again) ;)