Skip to content

Enable more user control over subvector type#4440

Merged
roystgnr merged 2 commits intolibMesh:develfrom
roystgnr:revert_subvector_workaround
Apr 24, 2026
Merged

Enable more user control over subvector type#4440
roystgnr merged 2 commits intolibMesh:develfrom
roystgnr:revert_subvector_workaround

Conversation

@roystgnr
Copy link
Copy Markdown
Member

In the future, default (AUTOMATIC type) subvectors will take on their supervector type, while other subvectors can retain a type specified in advance.

For now, we're still only going to support SERIAL->SERIAL and everything else ->PARALLEL (at least in parallel), but we'll mark other requested subvector creations as not implemented so we can keep those argument combinations unused for future implementation.

This is the next step (after the MOOSE PR that should hopefully be in CI for this by now) toward resolving the last bits of discussion in #4428 (comment)

In the future, default (AUTOMATIC type) subvectors will take on their
supervector type, while other subvectors can retain a type specified in
advance.

For now, we're still only going to support SERIAL->SERIAL and everything
else ->PARALLEL (at least in parallel), but we'll mark other requested
subvector creations as not implemented so we can keep those argument
combinations unused for future implementation.
@moosebuild
Copy link
Copy Markdown

Job Coverage, step Generate coverage on e6827c2 wanted to post the following:

Coverage

9334d7 #4440 e6827c
Total Total +/- New
Rate 65.47% 65.47% -0.00% 100.00%
Hits 78229 78228 -1 2
Misses 41253 41256 +3 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr roystgnr merged commit 10e93d6 into libMesh:devel Apr 24, 2026
25 checks passed
@roystgnr roystgnr deleted the revert_subvector_workaround branch April 24, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants