Add some more op function APIs to Communicator#156
Merged
Conversation
lindsayad
changed the title
And absorb existing sum,max,min implementations of those into macro
roystgnr
approved these changes
Dec 9, 2025
roystgnr
left a comment
roystgnr
left a comment
Member
There was a problem hiding this comment.
I'd strongly prefer to add some test coverage for these before merging, but beggars, choosers.
Member
Author
|
I will circle back to it in my train of work. Opened #157 and assigned myself to make sure I don't lose it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.