[11.0-stable] Give wwan microservice access to the config partition#3750
Merged
eriknordmark merged 1 commit intolf-edge:11.0-stablefrom Feb 9, 2024
Merged
[11.0-stable] Give wwan microservice access to the config partition#3750eriknordmark merged 1 commit intolf-edge:11.0-stablefrom
eriknordmark merged 1 commit intolf-edge:11.0-stablefrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 11.0-stable #3750 +/- ##
============================================
Coverage 20.30% 20.30%
============================================
Files 212 212
Lines 46071 46071
============================================
Hits 9354 9354
Misses 36034 36034
Partials 683 683 ☔ View full report in Codecov by Sentry. |
eriknordmark
approved these changes
Feb 9, 2024
Contributor
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
Can you make the commit message and the description refer to the commit/PR in master?
mmagent from the wwan microservice uses GetCipherCredentials to decrypt username/password for a cellular network. Internally, this depends on IsTpmEnabled() function, which determines the status of TPM by checking for the presence/absence of /config/device.cert.pem and /config/device.key.pem. This means that wwan container should have the config partition mounted as well, otherwise IsTpmEnabled() may return incorrect value and cause the decryption to fail. Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit 2dcaf10)
milan-zededa
force-pushed
the
11.0-stable
branch
from
5e75ae4 to
de7d908
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmagent from the wwan microservice uses
GetCipherCredentialsto decrypt username/password for a cellular network. Internally, this depends onIsTpmEnabled()function, which determines the status of TPM by checking for the presence/absence of/config/device.cert.pemand/config/device.key.pem. This means that wwan container should have the config partition mounted as well, otherwiseIsTpmEnabled()may return incorrect value and cause the decryption to fail.