Remove unused Vuetify styles from InfoModal.vue#5112
Remove unused Vuetify styles from InfoModal.vue#5112vtushar06 wants to merge 4 commits intolearningequality:unstablefrom vtushar06:remove-vuetify-infomodal
Conversation
|
Hi @MisRob 👋, |
|
Hi @vtushar06, thanks for the contribution. I will review and let you know. It will take few days. |
MisRob
left a comment
There was a problem hiding this comment.
Hi @vtushar06, thanks! This looks good to me. I'd like to request only one update. line-height actually takes effect, so we should preserve the style. However, we ideally wouldn't set it via ::v-deep but rather applied only in places when it's actually needed, which is basically just here
Would you wrap this license description in <p> and applied the smaller line height on it?
Then we can keep ::v-deep removal exactly the way you did.
|
Hi @MisRob, Thank you for the feedback and clarification! That makes perfect sense. I’ll go ahead and wrap the license description in a tag and apply the smaller line height there, as suggested. I’ll push the update shortly. Appreciate your time and review! 😊 |
|
Hi @MisRob , |
|
Thanks @vtushar06, would you be able to resolve conflicts? |
|
Hi @MisRob , Thanks again for your feedback and support! After running into some persistent issues with Git history, local conflicts, and rebase complications, I’ve decided to start fresh by deleting my fork and re-forking the repository to avoid any further confusion or hidden merge problems. I’ll reapply the changes (removing Vuetify styles and relocating the license description line-height), re-run all checks locally, and open a clean PR shortly. Thanks for your patience — I’ll tag you once the new PR is up! 🙌 Best, |
|
Hi @MisRob 👋, and applied the smaller line height on it |
|
Hi @vtushar06, yes I noticed - I will review |
|
okay @MisRob, Thank you so much |
Summary
This PR removes unused
::v-deepscoped styles from theInfoModal.vuecomponent that were referencing Vuetify-specific variables (e.g.,--v-grey-darken3). These styles were not affecting the rendered UI and are no longer needed, especially as part of the transition away from Vuetify.Manual Verification:
✅ No Vuetify-specific styles are used
✅ Functionality and layout remain unchanged
References
:v-deepstyles from info modalReviewer guidance
To test:
user@a.com/ password:aNote:
No visual differences should be present; the only change is cleanup of unused styles and removal of dependency on Vuetify color tokens.
…