Skip to content

Remove unused Vuetify styles from InfoModal.vue#5112

Closed
vtushar06 wants to merge 4 commits intolearningequality:unstablefrom
vtushar06:remove-vuetify-infomodal
Closed

Remove unused Vuetify styles from InfoModal.vue#5112
vtushar06 wants to merge 4 commits intolearningequality:unstablefrom
vtushar06:remove-vuetify-infomodal

Conversation

@vtushar06
Copy link
Copy Markdown
Contributor

Summary

This PR removes unused ::v-deep scoped styles from the InfoModal.vue component that were referencing Vuetify-specific variables (e.g., --v-grey-darken3). These styles were not affecting the rendered UI and are no longer needed, especially as part of the transition away from Vuetify.

Manual Verification:

  • Visited Settings > Storage > Request more space
  • Opened the About licenses modal using the info button near "Who can use your content?"
  • Manually forced the modal open by modifying visibility in the component since the button click is currently broken (as per instructions in the issue).
  • Confirmed that:
    • Modal renders correctly
    • Text styling remains consistent
    • No visual regressions observed

✅ No Vuetify-specific styles are used
✅ Functionality and layout remain unchanged


References


Reviewer guidance

To test:

  1. Log in using user@a.com / password: a
  2. Navigate to Settings > Storage > Request more space
  3. Open the info modal next to Who can use your content?
    • If the modal doesn't open, manually make it visible in the Vue component.
  4. Confirm that the text styling is intact and the modal displays as expected.

Note:

No visual differences should be present; the only change is cleanup of unused styles and removal of dependency on Vuetify color tokens.


@MisRob MisRob self-requested a review June 17, 2025 14:32
@MisRob MisRob self-assigned this Jun 17, 2025
@vtushar06
Copy link
Copy Markdown
Contributor Author

Hi @MisRob 👋,
Just checking in to see if you had a chance to review the PR. Let me know if anything needs to be updated or if further changes are required. Looking forward to your feedback
Thanks!

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Jun 18, 2025

Hi @vtushar06, thanks for the contribution. I will review and let you know. It will take few days.

Copy link
Copy Markdown
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vtushar06, thanks! This looks good to me. I'd like to request only one update. line-height actually takes effect, so we should preserve the style. However, we ideally wouldn't set it via ::v-deep but rather applied only in places when it's actually needed, which is basically just here

{{ translateConstant(`${item.license_name}_description`) }}

Would you wrap this license description in <p> and applied the smaller line height on it?

Then we can keep ::v-deep removal exactly the way you did.

@vtushar06
Copy link
Copy Markdown
Contributor Author

Hi @MisRob,

Thank you for the feedback and clarification! That makes perfect sense. I’ll go ahead and wrap the license description in a

tag and apply the smaller line height there, as suggested.

I’ll push the update shortly. Appreciate your time and review! 😊

@vtushar06

@vtushar06
Copy link
Copy Markdown
Contributor Author

Hi @MisRob ,
I’ve applied the requested change — the license description is now wrapped in a "p" tag with the appropriate line-height style applied directly.
Let me know if anything else is needed. Looking forward to your feedback!
@vtushar06

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Jun 20, 2025

Thanks @vtushar06, would you be able to resolve conflicts?

@vtushar06
Copy link
Copy Markdown
Contributor Author

Hi @MisRob ,

Thanks again for your feedback and support!

After running into some persistent issues with Git history, local conflicts, and rebase complications, I’ve decided to start fresh by deleting my fork and re-forking the repository to avoid any further confusion or hidden merge problems.

I’ll reapply the changes (removing Vuetify styles and relocating the license description line-height), re-run all checks locally, and open a clean PR shortly.

Thanks for your patience — I’ll tag you once the new PR is up! 🙌

Best,
Tushar (@vtushar06)

@vtushar06
Copy link
Copy Markdown
Contributor Author

Hi @MisRob 👋,
I have raise a new PR #5129 , which includes removal of unused ::v-deep scoped styles from the InfoModal.vue and wraped this license description in

and applied the smaller line height on it
Just checking in to see if you had a chance to review the PR. Let me know if anything needs to be updated or if further changes are required. Looking forward to your feedback
Thanks!

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Jun 20, 2025

Hi @vtushar06, yes I noticed - I will review

@vtushar06
Copy link
Copy Markdown
Contributor Author

okay @MisRob, Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Remove unused :v-deep styles from info modal

2 participants