refactor: provide a properly encapsulated implementation of OmegaLanguage#485
Merged
chenson2018 merged 5 commits intoleanprover:mainfrom Apr 20, 2026
Merged
refactor: provide a properly encapsulated implementation of OmegaLanguage#485chenson2018 merged 5 commits intoleanprover:mainfrom
chenson2018 merged 5 commits intoleanprover:mainfrom
Conversation
Collaborator
Author
|
Rebase on the current |
chenson2018
requested changes
Apr 13, 2026
Collaborator
chenson2018
left a comment
chenson2018
left a comment
There was a problem hiding this comment.
I'm a bit unsure about the coercion you added, but otherwise this looks good in following the Mathlib changes. Thanks for being proactive about this!
fmontesi
approved these changes
Apr 20, 2026
Collaborator
fmontesi
left a comment
fmontesi
left a comment
There was a problem hiding this comment.
LGTM after the last changes.
chenson2018
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a properly encapsulated implementation of OmegaLanguage, using a one-field
structure. It is influenced and will be affected by mathlib#36934, but it is not dependent on it.