feat: Add async FDv1 polling data source and feature requester - #475
Open
jsonbailey wants to merge 5 commits into
Open
feat: Add async FDv1 polling data source and feature requester#475jsonbailey wants to merge 5 commits into
jsonbailey wants to merge 5 commits into
Conversation
jsonbailey
marked this pull request as ready for review
July 30, 2026 22:03
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jsonbailey
force-pushed
the
jb/sdk-2825/async-fdv1-polling
branch
from
July 30, 2026 22:36
b8b7f52 to
16c4438
Compare
Drop the async feature requester's duplicate endpoint definition; use the shared constant from datasource_common instead.
- Don't set _ready on a generic poll exception, so a transient error during startup no longer ends start_wait early (matches sync). - Close the owned HTTP transport on stop: the feature requester tracks whether it created the transport and exposes close(); the polling processor awaits it. - Drop the dead 'all_data is not None' guard (the requester returns cached data on 304, never None) and the fictional None-return polling test.
AsyncRepeatingTask gains wait_stopped() to await the cancelled task; the polling processor's stop() now waits for the in-flight poll to unwind before closing the requester's transport, so awaiting stop() guarantees background work has stopped and the transport isn't closed under a live request.
jsonbailey
force-pushed
the
jb/sdk-2825/async-fdv1-polling
branch
from
August 4, 2026 16:32
fff0f5e to
5053397
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5053397. Configure here.
|
|
||
| # Signal VALID once the store is populated. | ||
| if self._store.initialized and self._data_source_update_sink is not None: | ||
| self._data_source_update_sink.update_status(DataSourceState.VALID, None) |
There was a problem hiding this comment.
VALID status requires store initialized
Medium Severity
After a successful poll, async polling only emits DataSourceState.VALID when _store.initialized is true. Sync polling and async streaming update to VALID whenever the sink is present after a successful init. With a custom sink that does not mark the shared store initialized, status can stay non-VALID even though data was delivered.
Reviewed by Cursor Bugbot for commit 5053397. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR 7 of the SDK-60 async epic: the async FDv1 polling data source and feature requester.
async_polling.py— async FDv1 polling update processor. Polls the feature requester on an interval and pushes flag/segment data into the data source update sink, updating data source status (VALID / OFF) as appropriate.async_feature_requester.py— async FDv1 feature requester that fetches the full flag/segment payload over HTTP.test_async_polling.py— unit tests for the async polling update processor.Stacking
This PR is stacked on #464 (base branch
jb/sdk-2743/async-fdv1-streaming), which provides the shareddatasource_commonmodule these files import. Until #464 merges, this PR will also show #464's commits in its diff; a rebase after #464 merges will drop them, leaving only the three files here.SDK-2825
Note
Medium Risk
Introduces a new async flag-loading data path tied to HTTP polling and store initialization; behavior aligns with sync polling but mistakes could affect client readiness or shutdown safety.
Overview
Adds the async FDv1 polling path so async clients can load flags and segments by polling instead of streaming, mirroring the existing sync
PollingUpdateProcessorbehavior.AsyncFeatureRequesterImplperforms HTTP GETs to the FDv1 poll endpoint with gzip, optional payload filter query params, and ETag / 304 caching so unchanged payloads reuse cached data.AsyncPollingUpdateProcessorruns polls on anAsyncRepeatingTaskinterval, initializes the feature store viasink_or_store, sets the ready event on first success, and updates data source status (VALID,INTERRUPTED, orOFFon unrecoverable HTTP errors).stop()waits for the in-flight poll to finish before closing the requester transport.AsyncRepeatingTask.wait_stopped()is new so shutdown can await task unwind afterstop()without closing the transport under a live request.Unit tests cover success, ETag cache, HTTP error handling, sink status updates, and stop ordering.
Reviewed by Cursor Bugbot for commit ca9d5b1. Bugbot is set up for automated code reviews on this repo. Configure here.