Repository navigation
Conversation
…napshot #111 removed set_openllmetry_completion and set_openllmetry_prompt from the package root, but the public-surface snapshot still listed them, so test_root_surface_is_exactly_the_snapshot fails on main.
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 570bcc4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main has failed since #111. That PR removed
set_openllmetry_completionandset_openllmetry_promptfrom the package root, butpackages/client/tests/test_public_surface.pystill lists both, sotest_root_surface_is_exactly_the_snapshotfails. Every open PR inherits the failure, because CI tests each PR merged with main.This removes the two names from the snapshot. No source changes.
Testing
uv run pytest: 2383 passed, 12 skipped.Note
Overview
Fixes CI by updating the checked-in
ROOT_SURFACEsnapshot intest_public_surface.pyso it matches the package root after #111 droppedset_openllmetry_completionandset_openllmetry_promptfromlaunchdarkly_ai_server.__all__.No runtime or library code changes—only the expected public export list used by
test_root_surface_is_exactly_the_snapshot.Reviewed by Cursor Bugbot for commit 570bcc4. Bugbot is set up for automated code reviews on this repo. Configure here.