Skip to content

test(client): drop the removed OpenLLMetry helpers from the surface snapshot - #167

Closed
apucacao wants to merge 1 commit into
mainfrom
fix/public-surface-snapshot
Closed

apucacao wants to merge 1 commit into
mainfrom
fix/public-surface-snapshot

Conversation

@apucacao

@apucacao apucacao commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

CI on main has failed since #111. That PR removed set_openllmetry_completion and set_openllmetry_prompt from the package root, but packages/client/tests/test_public_surface.py still lists both, so test_root_surface_is_exactly_the_snapshot fails. Every open PR inherits the failure, because CI tests each PR merged with main.

This removes the two names from the snapshot. No source changes.

Testing

  • uv run pytest: 2383 passed, 12 skipped.
  • The CI run for main at 9f0ece7 and 1389765 shows the one failing test this fixes.

Note

Overview
Fixes CI by updating the checked-in ROOT_SURFACE snapshot in test_public_surface.py so it matches the package root after #111 dropped set_openllmetry_completion and set_openllmetry_prompt from launchdarkly_ai_server.__all__.

No runtime or library code changes—only the expected public export list used by test_root_surface_is_exactly_the_snapshot.

Reviewed by Cursor Bugbot for commit 570bcc4. Bugbot is set up for automated code reviews on this repo. Configure here.

…napshot

#111 removed set_openllmetry_completion and set_openllmetry_prompt from the
package root, but the public-surface snapshot still listed them, so
test_root_surface_is_exactly_the_snapshot fails on main.
@apucacao

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 570bcc4. Configure here.

@apucacao
apucacao marked this pull request as ready for review October 13, 2026 17:38
@apucacao apucacao closed this Oct 14, 2026
@apucacao
apucacao deleted the fix/public-surface-snapshot branch October 14, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant