[abelonogov-ld]

Summary

ldcli sourcemaps upload only discovered web bundles (.js / .js.map), so React Native builds were skipped and the command failed with no .js.map files found. React Native's react-native bundle produces:

• iOS: main.jsbundle + main.jsbundle.map
• Android: index.android.bundle + index.android.bundle.map

This broadens the directory walk to also collect .jsbundle(.map) and .bundle(.map) files, via a shared isSourceMapUploadFile helper.

Why this resolves at lookup time (not just passing the filter)

Each map is uploaded under its own name, so its storage key is <version>/<basePath>/main.jsbundle.map. The backend looks up a frame's sourcemap as <frameFileName>.map (mapFileForJS), and React Native frames reference main.jsbundle / index.android.bundle — so the uploaded map matches. The minified bundle is uploaded alongside the map (mirroring how .js is uploaded with .js.map) so the backend can read its sourceMappingURL and resolve columns.

Repro (before)

$ react-native bundle --platform ios --dev false --entry-file index.js \
    --bundle-output ./build/main.jsbundle --sourcemap-output ./build/main.jsbundle.map
$ ldcli sourcemaps upload --app-version 1.0.0 --path ./build --project my-project
failed to find sourcemap files: no .js.map files found. Please double check that you have generated sourcemaps for your app

After this change the same command uploads main.jsbundle / main.jsbundle.map (and the Android equivalents) directly — no renaming needed.

Changes

• Add sourceMapUploadSuffixes + isSourceMapUploadFile and use it in getAllSourceMapFiles.
• Accept .jsbundle, .jsbundle.map, .bundle, .bundle.map in addition to .js / .js.map.
• Update the empty-result error message to reflect the broader set of patterns.

Test plan

• go test ./cmd/sourcemaps/... passes
• go build ./cmd/sourcemaps/... and gofmt clean
• New TestIsSourceMapUploadFile covers web + RN iOS/Android bundles/maps and rejects .css/.css.map/.md
• New TestGetAllSourceMapFilesReactNative verifies the four RN filenames are discovered and a non-sourcemap file is skipped
• Existing empty-dir assertion updated to the new message

Made with Cursor