Skip to content

fix: Redact anonymous context attributes in server-side custom events#583

Merged
keelerm84 merged 1 commit into
mainfrom
mk/SDK-2747/fix-custom-events
Jul 23, 2026
Merged

fix: Redact anonymous context attributes in server-side custom events#583
keelerm84 merged 1 commit into
mainfrom
mk/SDK-2747/fix-custom-events

Conversation

@keelerm84

@keelerm84 keelerm84 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

The C++ event processor emitted custom (track) events using the non-redacting context filter, so anonymous contexts were sent with all attributes intact. Server-side SDKs now redact all attributes of anonymous contexts in custom events (matching feature-event behavior); client-side SDKs continue to send them unredacted (they redact anonymous attributes only in feature events).

  • Gated the custom-event context filter on the SDK template type in AsioEventProcessor<SDK>::Process: FilterWithAnonymousRedaction for the server SDK, Filter for the client SDK.
  • Mirrors the redactAnonymousAllEvents split in java-core / dotnet-core.
  • Verified against the sdk-test-harness v3 custom-event tests: server redacts, client does not.

Note

Medium Risk
Changes what PII/context data leaves server-side custom events (privacy fix), but scope is limited to one code path and mirrors existing feature-event filtering.

Overview
Server-side custom (track) events now run context through FilterWithAnonymousRedaction before emission, so anonymous contexts no longer ship with full attributes in those payloads. Client SDK track events still use the standard Filter path, unchanged.

The branch is chosen in AsioEventProcessor<SDK>::Process from the SDK template type, aligning track events with how full feature events already redact anonymous context on the server and with redactAnonymousAllEvents behavior in other SDKs.

Reviewed by Cursor Bugbot for commit da0f065. Bugbot is set up for automated code reviews on this repo. Configure here.

@keelerm84
keelerm84 requested a review from a team as a code owner July 23, 2026 14:45
@keelerm84 keelerm84 changed the title Redact anonymous context attributes in server-side custom events fix: Redact anonymous context attributes in server-side custom events Jul 23, 2026
@keelerm84
keelerm84 merged commit 55f7eaf into main Jul 23, 2026
49 of 52 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-2747/fix-custom-events branch July 23, 2026 17:29
@github-actions github-actions Bot mentioned this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants