Repository navigation
Use Thread.join instead of sleep in WaitTest - #4971
Open
therealemmanueloppong wants to merge 1 commit into
Open
therealemmanueloppong wants to merge 1 commit into
therealemmanueloppong wants to merge 1 commit into
Conversation
pollShutsDownExecutorThreadAfterReturning waited for the worker thread to stop with a hand-written loop that slept 10 ms between checks. Use Thread.join with the same 2 second limit, which waits for exactly the event the test cares about and removes the Thread.sleep. Part of kubernetes-client#1223.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: therealemmanueloppong The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
cncf-cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Thank you for maintaining this project.
WaitTest.pollShutsDownExecutorThreadAfterReturningwaits for the worker thread to terminate with a hand-written loop that callsThread.sleep(10)betweenisAlive()checks, up to a 2 second deadline.Thread.join(2000)waits for exactly that event with the same upper limit, so the loop and theThread.sleepcan go away.Behaviour is unchanged: the test still waits up to 2 seconds for the worker to stop and then asserts that it is no longer alive. This is a small cleanup and not a speed-up, since the test already finished in well under 0.1 seconds. I only changed this one test file.
Related issue
Part of #1223
Testing
WaitTestpasses (ran it 3 times).mvn spotless:checkpasses for theutilmodule.