Repository navigation
Remove Thread.sleep from DefaultDelayingQueueTest - #4970
Open
therealemmanueloppong wants to merge 1 commit into
Open
therealemmanueloppong wants to merge 1 commit into
therealemmanueloppong wants to merge 1 commit into
Conversation
simpleDelayingQueue waited a fixed 10 seconds before checking that the queue stayed empty. Poll until nothing is left waiting to be added instead, which is deterministic and takes the test from about 10.5s to about 0.5s. Part of kubernetes-client#1223.
kubernetes-prow
Bot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: therealemmanueloppong The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/assign @brendandburns Thank you for taking a look when you have time. I am happy to change anything you would like different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Thank you for maintaining this project.
simpleDelayingQueueinDefaultDelayingQueueTestended with a fixedThread.sleep(10 * 1000L)before checking that the queue stayed empty. That makes the test take about 10 seconds and is the kind of timing wait that #1223 asks to replace.The only entry in that test has already been released and marked done by that point, so once nothing is left waiting to be added the queue cannot receive anything else. The test now polls for that with the existing
waitForWaitingQueueToFillhelper and then asserts the length, so there is no fixed wait.I changed only this one test file, and nothing else in the class. An alternative would be to make the sleep shorter, but that would still depend on timing.
Related issue
Part of #1223
Testing
DefaultDelayingQueueTest(3 tests) passes. The class went from about 10.5 s to about 0.5 s, and I ran it 3 times with the same result.mvn spotless:checkpasses for theextendedmodule.