Repository navigation
Conversation
U+FEFF is part of a filename, even when its UTF-8 bytes begin an octal-escaped run. Tell TextDecoder to retain it instead of treating it as a BOM. Signed-off-by: Don Yin <Don_Yin@outlook.com>
Author
|
Gentle ping on this one whenever you have time. No rush, happy to change anything. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parsePatchcurrently treats the start of each octal-escaped byte run as a possible BOM. Fora\uFEFFnote.txt, Git writesa\357\273\277note.txt, but the parsed filename becomesanote.txt.This sets
ignoreBOM: trueso U+FEFF stays part of the filename. The added test covers leading, embedded, path-component, and consecutive U+FEFF characters, checkingoldFileName,newFileName, andindex.I also checked actual
git diffoutput for these four filenames. The plot counts retained U+FEFF characters; labels show the character as\uFEFF.Tests:
yarn run-mocha --grep 'preserve a U': 0 passing / 1 failing before; 1 passing after.yarn test: 327 passing, including lint, both builds, type checks, and coverage gates.