Skip to content

fix: edited and push sync across reloads.#89

Merged
knightedcodemonkey merged 2 commits intonextfrom
bananas
Apr 20, 2026
Merged

fix: edited and push sync across reloads.#89
knightedcodemonkey merged 2 commits intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 20, 2026 02:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes workspace edited/push-sync state persistence across reloads by making PR file targeting derive reliably from tab paths (avoiding stale targetPrFilePath collisions), and by tightening how sync reconciliation treats primary vs non-primary tabs.

Changes:

  • Normalize/derive targetPrFilePath from tab.path (especially for module tabs) to prevent stale target path collisions across reloads.
  • Update workspace sync reconciliation to avoid overwriting non-primary module tabs during editor sync and to dedupe commits when paths collide with primary tabs.
  • Refresh edited indicators after push reconciliation and add Playwright coverage for the new behaviors.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/modules/workspace/workspace-tab-shape.js Recomputes targetPrFilePath from normalized paths to prevent stale target metadata after reload.
src/modules/app-core/workspace-sync-controller.js Adjusts push/editor sync reconciliation logic to treat primary tabs differently and avoid module overwrite/collisions.
src/app.js Refreshes edited indicators after push reconciliation and reloads the active tab after active-context sync.
playwright/github-pr-drawer.spec.ts Adds coverage for dirty-state clearing, stale target-path collision handling, and reload sync behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread playwright/github-pr-drawer.spec.ts Outdated
Comment thread src/modules/app-core/workspace-sync-controller.js Outdated
@knightedcodemonkey knightedcodemonkey merged commit a77ece6 into next Apr 20, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 20, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants